Skip to content

Commit

Permalink
Fix login from localhost
Browse files Browse the repository at this point in the history
Login from localhost/studio.localhost was broken on Ironwood because the
session cookie was configured to be stored under the production domain
name. We fix this by setting the SESSION_COOKIE_DOMAIN to None: in the
edx-platform code, this corresponds to using the current request domain.
  • Loading branch information
regisb committed Mar 27, 2019
1 parent 7c0f3f2 commit e2b0f3b
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## v3.3.3 (2019-03-27)

- [Bugfix] Fix login from localhost

## v3.3.2 (2019-03-27)

- [Bugfix] Fix Android app image build
Expand Down
2 changes: 1 addition & 1 deletion tutor/templates/apps/openedx/config/cms.env.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"EMAIL_PORT": {{ SMTP_PORT }},
"HTTPS": "{{ "on" if ACTIVATE_HTTPS else "off" }}",
"LANGUAGE_CODE": "{{ LANGUAGE_CODE }}",
"SESSION_COOKIE_DOMAIN": ".{{ lms_cms_common_domain }}",
{% if ACTIVATE_HTTPS %}"SESSION_COOKIE_DOMAIN": ".{{ lms_cms_common_domain }}",{% endif %}
"CACHES": {
"default": {
"KEY_PREFIX": "default",
Expand Down
1 change: 0 additions & 1 deletion tutor/templates/apps/openedx/config/lms.env.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@
{% endif %}
"LANGUAGE_CODE": "{{ LANGUAGE_CODE }}",
"LOGIN_REDIRECT_WHITELIST": ["{{ CMS_HOST }}", "studio.localhost"],
"SESSION_COOKIE_DOMAIN": ".{{ lms_cms_common_domain }}",
"CACHES": {
"default": {
"KEY_PREFIX": "default",
Expand Down

0 comments on commit e2b0f3b

Please sign in to comment.