Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Testing and Linting #32

Merged
merged 7 commits into from
Dec 8, 2023
Merged

Conversation

CodeWithEmad
Copy link
Member

@CodeWithEmad CodeWithEmad commented Nov 18, 2023

Assorted testing and linting improvements:

  • Makefile with test and lint targets
  • Long lines reformated with black
  • Sort imports with isort

In addition:

  • Typing added for various functions
  • All configs moved to 1 place and init.sh renamed to init to better support the unification of plugins

@FahadKhalid210
Copy link
Contributor

Hi @CodeWithEmad Thanks for the PR. I will look into it.

tutorminio/plugin.py Outdated Show resolved Hide resolved
tutorminio/plugin.py Outdated Show resolved Hide resolved
tutorminio/plugin.py Outdated Show resolved Hide resolved
tutorminio/plugin.py Outdated Show resolved Hide resolved
tutorminio/plugin.py Outdated Show resolved Hide resolved
@CodeWithEmad CodeWithEmad force-pushed the feat/test-lint branch 2 times, most recently from 1a2ef7b to 4a61cc0 Compare November 27, 2023 09:25
@CodeWithEmad
Copy link
Member Author

dev dependency added.

Copy link
Contributor

@regisb regisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@regisb regisb merged commit 540a7a9 into overhangio:master Dec 8, 2023
1 check passed
@regisb
Copy link
Contributor

regisb commented Dec 8, 2023

@FahadKhalid210 I'm taking the liberty to merge to close as many PRs as possible before Quince.

@CodeWithEmad CodeWithEmad deleted the feat/test-lint branch December 8, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants