-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Upgrade to Quince #31
Merged
+11
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to address overhangio/tutor-mfe#122 As a consequence of this change, images will be tagged with a "-nightly" suffix. Next, we'll probably have to build them periodically in CI.
The package version number may not include the "-nightly" suffix. Otherwise, installation fails with: setuptools.extern.packaging.version.InvalidVersion: Invalid version: '15.0.7-nightly'
The value for AWS_S3_ENDPOINT_URL set in openedx-development-settings specifies port 9000, and it was being written to Studio and LMS settings correctly. But this is the sequence of what was really happening: 1. openedx-common-settings first sets AWS_S3_ENDPOINT_URL WITHOUT port info, since this is how it's used in prod deployments. 2. openedx-common-settings imports S3Boto3Storage because it wants to make a subclass to use for USER_TASKS_ARTIFACT_STORAGE. 3. The act of importing that pacakge has the side-effect of initializing Django storages and sets up the default storage object (django.core.files.storage.default_storage). 4. Because the DEFAULT_FILE_STORAGE class is S3Boto3Storage, it then reads the value of AWS_S3_ENDPOINT_URL (which has no port info), and sets this as the S3 connection information for the S3Boto3Storage instance at that time. 5. openedx-development-settings then comes along and changes the value of AWS_S3_ENDPOINT_URL to specify port 9000, but by this point it's too late to affect django-storages (though it will confuse folks who try to debug). The value is ignored. This commit removes the import that was causing the premature Django storages initialization. The patch is no longer necessary because ImportExportS3Storage was already moved to use S3Boto3Storage in edx-platform 31002ab (it is included in the Palm release).
regisb
reviewed
Nov 28, 2023
There's an issue with profile photo upload openedx/wg-build-test-release#333 |
regisb
force-pushed
the
quince
branch
3 times, most recently
from
December 11, 2023 17:12
e4a7f42
to
ff7f998
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upgrade to quince
#29