-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Testing and Linting #155
Conversation
ff15b00
to
8fc8ed4
Compare
@regisb Should I modify the |
fbb24e5
to
7612a41
Compare
Yes, good idea!
I think that's convenient, yes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's a great step forward, and the PR looks good as it is. @arbrandes and @kdmccormick I'm curious to hear what you think?
69a753a
to
829dc9a
Compare
I'm happy to hear that! black and isort steps added and gh_refs_path reformatted. |
829dc9a
to
df74770
Compare
I have resolved the conflicts that were caused by merging my last pull request. Also I had another thing in mind. Shouldn't we update documents to inform contributors about running |
df74770
to
09ef180
Compare
Just a friendly reminder @kdmccormick @arbrandes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for you patience @CodeWithEmad . I think this is a great improvement!
My only concern is that we should pin the development dependencies in order to keep the PR build stable--see my comment below.
09ef180
to
ff015db
Compare
instead of only returning heads or tags, and appending it to a GitHub url, the function now accepts an owner and a name and return the full refs path
ff015db
to
708f607
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot Emad! This is very useful. I'll let @arbrandes review, squash and merge.
This will add a Makefile, clean the code with isort and black, and fix typing issues.
Closes #151