set the value of cmi.mode #64
Conversation
|
@ziafazal Could you please review this PR? |
There was a problem hiding this comment.
In general, try to explain in your commit title why you are making this change. Are you fixing a bug? Implementing a new feature? Why is it needed?
In your commit message, you can then explain what you are doing. In this particular case, "what" you are doing is to set the value of cmi.mode. "Why" we need to do this, that I have no idea just by reading the PR...
|
In this commit, I addressed the issue related to SCORM attempts not being set correctly. https://github.com/orgs/overhangio/projects/4/views/1?pane=issue&itemId=37732590. |
|
Great explanation! You should add this to your git commit description. |
There was a problem hiding this comment.
@rimsha-zaib overall look. I have a question and a suggestion. Just wondering is there any way we can get hostname on server side e.g self.runtime.hostname instead of sending it from javascript?
| }), | ||
| async: false, | ||
| success: function (response) { |
There was a problem hiding this comment.
why we have to remove this success handler?
There was a problem hiding this comment.
Unable to retrieve user mode through self.runtime. Although runtime has a handleurl function , isn't returning correct URLs.
There was a problem hiding this comment.
Synchronous AJAX call within GetValue does not properly return the response value in success handler, resulting in an empty string. This causes GetValue to be called twice, so the mode is not being set in this case.
There was a problem hiding this comment.
I'm not getting it why synchronous AJAX call within GetValue does not properly return the response value?
openedxscorm/scormxblock.py
Outdated
|
|
||
| @XBlock.json_handler | ||
| def scorm_get_value(self, data, _suffix): | ||
| """ | ||
| Here we get only the get_value events that were not filtered by the LMSGetValue js function. | ||
| """ | ||
| name = data.get("name") | ||
| if name in ["cmi.core.lesson_mode", "cmi.mode"]: | ||
| mode = self.get_mode(data) |
There was a problem hiding this comment.
nit: can merge these two lines to simplify these
| mode = self.get_mode(data) | |
| return {"value": self.get_mode(data)} |
* fix: set the value of cmi.mode
No description provided.