fix: Add querystring to S3 signed url if it is present in the proxy request #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -195,7 +195,7 @@ def author_view(self, context=None): | |||
|
|
|||
| def student_view(self, context=None): | |||
| student_context = { | |||
| "index_page_url": self.index_page_url, | |||
| "index_page_url": urllib.parse.unquote(self.index_page_url), | |||
There was a problem hiding this comment.
We should also pass our navigation_title links through urllib.parse.unquote as well as tagged below.
We should change it to something like:
resource_link = urllib.parse.unquote(self.storage.url(os.path.join(self.extract_folder_path, resource.get("href"))))
Danyal-Faheem
suggested changes
Jan 19, 2024
Danyal-Faheem
approved these changes
Jan 19, 2024
ziafazal
added a commit
that referenced
this pull request
May 27, 2024
…equest (#61) * fix: Add querystring to S3 signed url if it is present in the proxy request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has these changes