Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli/init): new repos use text-based lockfile #16295

Closed

Conversation

DonIsaac
Copy link
Contributor

@DonIsaac DonIsaac commented Jan 9, 2025

What does this PR do?

Repos initialized with bun init now get a bunfig.toml file that sets install.saveTextLockfile to true.

We should probably remove this before the v1.2 release.

How did you verify your code works?

I wrote automated tests

@robobun
Copy link

robobun commented Jan 9, 2025

Updated 9:00 PM PT - Jan 10th, 2025

@DonIsaac, your commit a81b130 has some failures in #9427


🧪   try this PR locally:

bunx bun-pr 16295

Copy link
Contributor Author

DonIsaac commented Jan 9, 2025

@DonIsaac DonIsaac requested a review from dylan-conway January 9, 2025 22:13
@DonIsaac DonIsaac marked this pull request as ready for review January 9, 2025 22:14
@DonIsaac DonIsaac force-pushed the 01-09-refactor_cli_init_deduplicate_asset_creation_logic branch from d918825 to e0f08ac Compare January 11, 2025 01:14
@DonIsaac DonIsaac force-pushed the 01-09-feat_cli_init_new_repos_use_text-based_lockfile branch from adfcb9a to 63952ed Compare January 11, 2025 01:14
Base automatically changed from 01-09-refactor_cli_init_deduplicate_asset_creation_logic to main January 11, 2025 02:40
@DonIsaac DonIsaac force-pushed the 01-09-feat_cli_init_new_repos_use_text-based_lockfile branch from 63952ed to a81b130 Compare January 11, 2025 04:18
@DonIsaac DonIsaac force-pushed the 01-09-feat_cli_init_new_repos_use_text-based_lockfile branch from a81b130 to 254133c Compare January 11, 2025 05:00
@DonIsaac
Copy link
Contributor Author

the release is so soon that this PR isn't really worth it anymore.

@DonIsaac DonIsaac closed this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants