get node:fs tests passing part 1 #16270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated 7:02 PM PT - Jan 14th, 2025
✅ @paperclover, your commit 91048cc has passed in 🧪 try this PR locally: bunx bun-pr 16270 |
note: bun shell keeps uppercase
Co-authored-by: Dylan Conway <[email protected]> Co-authored-by: Michael H <[email protected]>
Co-authored-by: RiskyMH <[email protected]>
@nektro we can't use .call in builtins
… chloe/node-fs-1
src/sys.zig
Outdated
| // enough bytes for a path alongside an error message and code. | ||
| // format taken from Node.js 'exceptions.cc' | ||
| // search keyword: `Local<Value> UVException(Isolate* isolate,` | ||
| var message_buf: [bun.MAX_PATH_BYTES + 2048]u8 = undefined; |
There was a problem hiding this comment.
Use the buffer pool for this to avoid allocating 66 KB of stack space
src/js/node/fs.promises.ts
Outdated
| try { | ||
| this[kRef](); | ||
| console.log({ fd, buffer, offset, length, position }); |
There was a problem hiding this comment.
Suggested change
| console.log({ fd, buffer, offset, length, position }); |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr contains work towards getting node.js test for
node:fsto pass.note: this is a draft pr. opening early to get a ci run to see where regressions land
non-nodefs changes:
--expose-internals. this was the wrong strategy to pass node tests. to migrate, rewrite all uses of internalBinding to process.binding.