Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transpiler: dont inline import.meta.require #16222

Merged
merged 7 commits into from
Jan 8, 2025
Merged

Conversation

paperclover
Copy link
Member

@paperclover paperclover commented Jan 7, 2025

this vastly simplifies things and fixes #15738

additionally:
fixes node builtin error message regression:
image

@robobun
Copy link

robobun commented Jan 7, 2025

Updated 11:02 PM PT - Jan 7th, 2025

@paperclover, your commit 555d004 has 2 failures in #9198:

  • test/js/bun/http/serve-body-leak.test.ts - timeout on 🪟 2019 x64-baseline
  • test/js/bun/http/serve-body-leak.test.ts - timeout on 🪟 2019 x64
  • Failed to create agent for 🐧 x64-musl - build-vendor
  • VcpuLimitExceededYou have requested more vCPU capacity than your current vCPU limit of 6146 allows for the instance bucket that the specified instance type belongs to. Please visit http://aws.amazon.com/contact-us/ec2-request to request an adjustment to this limit.0f48a3f7-4ffd-4f0b-8861-83fda1bb1ff3
  • Failed to create agent for 🐧 x64 - build-vendor
  • VcpuLimitExceededYou have requested more vCPU capacity than your current vCPU limit of 6146 allows for the instance bucket that the specified instance type belongs to. Please visit http://aws.amazon.com/contact-us/ec2-request to request an adjustment to this limit.dd47d1af-a3b2-4149-94ad-ba46cd5aba74

🧪   try this PR locally:

bunx bun-pr 16222

@paperclover paperclover marked this pull request as draft January 7, 2025 22:04
@Jarred-Sumner Jarred-Sumner marked this pull request as ready for review January 8, 2025 07:14
@Jarred-Sumner Jarred-Sumner merged commit a3cbf97 into main Jan 8, 2025
55 of 58 checks passed
@Jarred-Sumner Jarred-Sumner deleted the chloe/vite-fix branch January 8, 2025 07:14
@kunl
Copy link

kunl commented Jan 9, 2025

bun 1.1.43 works normally 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bunx --bun vite build error during build: [vite:css] import.meta is only valid inside modules.
4 participants