Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update $ERR_INVALID_ARG_VALUE callsites #16202

Merged
merged 1 commit into from
Jan 7, 2025
Merged

update $ERR_INVALID_ARG_VALUE callsites #16202

merged 1 commit into from
Jan 7, 2025

Conversation

nektro
Copy link
Member

@nektro nektro commented Jan 7, 2025

#16194 followup audit

@robobun
Copy link

robobun commented Jan 7, 2025 •
edited
Loading

Updated 8:16 PM PT - Jan 6th, 2025

❌ @nektro, your commit 39beb39 has 1 failures in #9058:

🧪   try this PR locally:

bunx bun-pr 16202

@nektro nektro marked this pull request as ready for review January 7, 2025 05:22
@nektro nektro requested a review from Jarred-Sumner January 7, 2025 05:22
@Jarred-Sumner Jarred-Sumner merged commit ace4595 into main Jan 7, 2025
64 of 67 checks passed
@Jarred-Sumner Jarred-Sumner deleted the nektro-patch-10869 branch January 7, 2025 07:51
probably-neb pushed a commit to probably-neb/bun that referenced this pull request Jan 7, 2025
@nektro @probably-neb
update $ERR_INVALID_ARG_VALUE callsites (oven-sh#16202)
fd6b7cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarred-Sumner Jarred-Sumner Awaiting requested review from Jarred-Sumner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nektro @robobun @Jarred-Sumner