Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(js/builtins): add PullIntoDescriptor type definitions #16190

Open
wants to merge 1 commit into
base: don/test/dequeue
Choose a base branch
from

Conversation

DonIsaac
Copy link
Contributor

@DonIsaac DonIsaac commented Jan 6, 2025

What does this PR do?

Adds a type definition for PullIntoDescriptor and annotates consuming code.

How did you verify your code works?

Only type changes. No logic is affected.

Copy link
Contributor Author

DonIsaac commented Jan 6, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@DonIsaac DonIsaac force-pushed the 01-06-chore_js_builtins_add_pullintodescriptor_type_definitions branch from 65d4699 to 2e80ea0 Compare January 6, 2025 23:04
@DonIsaac DonIsaac marked this pull request as ready for review January 6, 2025 23:04
@DonIsaac DonIsaac force-pushed the 01-06-chore_js_builtins_add_pullintodescriptor_type_definitions branch from 2e80ea0 to 8ead628 Compare January 7, 2025 00:34
@robobun
Copy link

robobun commented Jan 7, 2025

Updated 8:47 PM PT - Jan 6th, 2025

@DonIsaac, your commit cb755dc has 1 failures in #9061:


🧪   try this PR locally:

bunx bun-pr 16190

@DonIsaac DonIsaac force-pushed the 01-06-chore_js_builtins_add_pullintodescriptor_type_definitions branch from 8ead628 to cb755dc Compare January 7, 2025 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants