Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: S3 improvements #16167

Merged
merged 28 commits into from
Jan 5, 2025
Merged

WIP: S3 improvements #16167

merged 28 commits into from
Jan 5, 2025

Conversation

cirospaciari
Copy link
Member

@cirospaciari cirospaciari commented Jan 4, 2025

Changes:

  • Add .delete alias to unlink
  • Fix region detection
  • Add test for region and endpoint detection
  • Re-add static methods on Bucket
  • Reorganize S3 Client code
  • Improve download stream reliability
  • Add download stream reliability tests

What does this PR do?

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

Tests

@robobun
Copy link

robobun commented Jan 4, 2025

Updated 1:53 PM PT - Jan 4th, 2025

@cirospaciari, your commit f5a7f0a has 1 failures in #8990:


🧪   try this PR locally:

bunx bun-pr 16167

@cirospaciari cirospaciari force-pushed the ciro/s3-fixes-and-refactor-more branch from aef8aa2 to 1bc7df6 Compare January 4, 2025 17:41
@cirospaciari cirospaciari changed the title wip s3 refactor + fix + tests WIP: S3 improvements Jan 4, 2025
@Jarred-Sumner Jarred-Sumner marked this pull request as ready for review January 5, 2025 03:57
@Jarred-Sumner Jarred-Sumner merged commit 034f776 into main Jan 5, 2025
64 of 67 checks passed
@Jarred-Sumner Jarred-Sumner deleted the ciro/s3-fixes-and-refactor-more branch January 5, 2025 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants