Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: repair lint setup and run it in CI #15720

Merged
merged 14 commits into from
Jan 8, 2025
Merged

ci: repair lint setup and run it in CI #15720

merged 14 commits into from
Jan 8, 2025

Conversation

DonIsaac
Copy link
Contributor

What does this PR do?

  • Replace eslint with oxlint, which was not configured correctly. Before this PR, bun lint simply crashed.
  • Configure oxlint to only look for a set of strictly incorrect code
  • Add a lint job to CI. While bun lint will display warnings locally, this job will not.
  • Fix error-level lint rule violations found. These are strictly (minor) bug fixes.

How did you verify your code works?

Build + test locally

@DonIsaac DonIsaac requested a review from Electroid December 12, 2024 01:50
@robobun
Copy link

robobun commented Dec 12, 2024

Updated 11:12 PM PT - Jan 7th, 2025

@DonIsaac, your commit 3eb2827 has passed in #9206! 🎉


🧪   try this PR locally:

bunx bun-pr 15720

@Jarred-Sumner
Copy link
Collaborator

Jarred-Sumner commented Dec 12, 2024

I think we're going to need to be very specific of what files have which linter rules apply. We necessarily do weird things in various tests. Things like ReferenceError should definitely be caught, but most stylistic opinions should be enforced by formatter and not by linter

And I don't think spending the time fixing made-up linter errors is higher priority than improving the Node.js passing test %

@DonIsaac
Copy link
Contributor Author

@Jarred-Sumner I've greatly narrowed the scope of files subject to linting. You'll find the full list in the ignorePatterns property in oxlint.json. I'm also only checking for correctness issues. I've already found a precedence bug in node:stream.

@DonIsaac DonIsaac added this pull request to the merge queue Jan 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 6, 2025
@DonIsaac DonIsaac enabled auto-merge January 8, 2025 00:43
@DonIsaac DonIsaac added this pull request to the merge queue Jan 8, 2025
@DonIsaac DonIsaac removed this pull request from the merge queue due to a manual request Jan 8, 2025
@DonIsaac DonIsaac enabled auto-merge January 8, 2025 01:30
@DonIsaac DonIsaac added this pull request to the merge queue Jan 8, 2025
Merged via the queue into main with commit 81ecf75 Jan 8, 2025
68 checks passed
@DonIsaac DonIsaac deleted the don/fix/lint branch January 8, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants