-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make AbortSignal.timeout() 6x faster #15387
Open
Jarred-Sumner
wants to merge
17
commits into
main
Choose a base branch
from
jarred/change-timers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+683
−534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarred-Sumner
changed the title
Make AbortSignal.timeout() 10x faster
Make AbortSignal.timeout() 6 faster
Nov 24, 2024
Jarred-Sumner
changed the title
Make AbortSignal.timeout() 6 faster
Make AbortSignal.timeout() 6x faster
Nov 24, 2024
cirospaciari
requested changes
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests failures
Please make abortSignal timeout works (#13302) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This makes it so the only usage of
us_create_timer
is the sweep and date timers used byus_loop_t
. The GC timers and AbortSignal.timeout use the timer heap. This will have memory usage implications so we need to measure memory usage changes in some scenarios before merging this.This also switches the list of pending fetch() calls to shutdown to a HashMap instead of an ArrayHashMap, and swaps the multi-threaded queue of shutdowns
Stress test below gets 10x faster:
Code:
How did you verify your code works?