Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with --eval & --print #15379

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Conversation

Jarred-Sumner
Copy link
Collaborator

What does this PR do?

Cherry-picks some of @nektro's changes, with a modification fixing the blocker for string_decoder and other natively implemented ESM modules to appear in globals

How did you verify your code works?

Assertion in debug build no longer triggers

@robobun
Copy link

robobun commented Nov 24, 2024

@Jarred-Sumner, your commit d919f7b has 16 failures in #6779:

  • test/js/node/test/parallel/worker-nested-uncaught.test.js - segmentation fault on 🐧 3.20 aarch64
  • test/js/node/test/parallel/worker-nested-uncaught.test.js - segmentation fault on 🐧 3.20 x64
  • test/js/node/test/parallel/worker-nested-uncaught.test.js - segmentation fault on 🐧 3.20 x64-baseline
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 aarch64
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 x64
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 x64-baseline
  • test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🐧 3.20 x64
  • test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🐧 3.20 x64-baseline
  • test/cli/install/registry/bun-install-registry.test.ts - timeout on 🐧 22.04 x64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 22.04 x64-baseline
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 12 x64-baseline
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 22.04 x64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 3.20 aarch64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 3.20 x64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 3.20 x64-baseline
  • test/integration/next-pages/test/next-build.test.ts - 1 failing on 🐧 22.04 x64
  • test/js/node/child_process/child_process.test.ts - 1 failing on 🐧 3.20 aarch64
  • test/js/node/child_process/child_process.test.ts - 1 failing on 🐧 3.20 x64
  • test/js/node/child_process/child_process.test.ts - 1 failing on 🐧 3.20 x64-baseline
  • test/cli/install/bun-link.test.ts - 4 failing on 🐧 3.20 aarch64
  • test/cli/install/bun-link.test.ts - 4 failing on 🐧 3.20 x64
  • test/cli/install/bun-link.test.ts - 4 failing on 🐧 3.20 x64-baseline
  • test/js/deno/performance/performance.test.ts - 1 failing on 🐧 22.04 aarch64
  • test/js/bun/spawn/spawn.test.ts - timeout on 🪟 2019 x64
  • test/js/web/timers/setInterval.test.js - 1 failing on 🪟 2019 x64
  • test/js/web/fetch/fetch.tls.test.ts - 1 failing on 🍎 14 aarch64
  • test/js/node/test/parallel/child-process-exec-timeout-kill.test.js - 1 failing on 🍎 13 aarch64
  • test/js/bun/http/serve.test.ts - 1 failing on 🍎 14 aarch64
  • test/js/bun/http/serve.test.ts - 1 failing on 🍎 13 aarch64
  • test/js/bun/http/serve.test.ts - segmentation fault on 🐧 3.20 aarch64
  • test/js/bun/http/serve.test.ts - segmentation fault on 🐧 3.20 x64
  • test/js/bun/http/serve.test.ts - segmentation fault on 🐧 3.20 x64-baseline
  • test/cli/run/require-cache.test.ts - 1 failing on 🪟 2019 x64
  • test/cli/run/require-cache.test.ts - 1 failing on 🪟 2019 x64-baseline
  • test/js/node/test/parallel/fs-watch-recursive-update-file.test.js - 1 failing on 🍎 14 aarch64
  • @dylan-conway dylan-conway merged commit a6f37b3 into main Nov 25, 2024
    65 of 67 checks passed
    @dylan-conway dylan-conway deleted the jarred/bug-with-customvalue branch November 25, 2024 20:58
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants