ci: merge clang-format and clang-tidy into single pipeline #14798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing this! Looks good, I’ll update the branch protection settings |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Merges
clang-formatandclang-tidyinto a single workflow/job calledclangWhy?
clang-formatandclang-tidytake roughly a minute each. Most of that time is spent on setup, primarily on LLVM installation. Additionally, both use the same exact environment variables and steps (except for the format vs tidy part). Merging these together will reduce GH actions CI time spent. Not by much mind you, but if this runs on each PR it could be worth it.Risks & Alternatives
If we merge this PR, we need to update
main's branch protections to useclang, then removeclang-formatandclang-tidyas required workflows.If we like having these separate for viewing/comprehension reasons, we could combine these workflows into one but use separate jobs. This negates CI waste benefits and is more of a style preference.