fix(install): tarball extracting bugfix (#11864)

Co-authored-by: Jarred Sumner <[email protected]>

misctools/tgz.zig

@@ -88,8 +88,9 @@ pub fn main() anyerror!void {
         null,
         void,
         void{},
-        1,
-        false,
-        false,
+        .{
+            .depth_to_skip = 1,
+            .close_handles = false,
+        },
     );
 }

src/bun.zig

@@ -3260,6 +3260,19 @@ noinline fn assertionFailure() noreturn {
     Output.panic("Internal assertion failure", .{});
 }
 
+noinline fn assertionFailureWithLocation(src: std.builtin.SourceLocation) noreturn {
+    if (@inComptime()) {
+        @compileError("assertion failure");
+    }
+
+    @setCold(true);
+    Output.panic("Internal assertion failure {s}:{d}:{d}", .{
+        src.file,
+        src.line,
+        src.column,
+    });
+}
+
 pub inline fn debugAssert(cheap_value_only_plz: bool) void {
     if (comptime !Environment.isDebug) {
         return;
@@ -3281,6 +3294,17 @@ pub fn assert(value: bool) callconv(callconv_inline) void {
     }
 }
 
+pub fn assertWithLocation(value: bool, src: std.builtin.SourceLocation) callconv(callconv_inline) void {
+    if (comptime !Environment.allow_assert) {
+        return;
+    }
+
+    if (!value) {
+        if (comptime Environment.isDebug) unreachable;
+        assertionFailureWithLocation(src);
+    }
+}
+
 /// This has no effect on the real code but capturing 'a' and 'b' into parameters makes assertion failures much easier inspect in a debugger.
 pub inline fn assert_eql(a: anytype, b: anytype) void {
     return assert(a == b);

src/cli/create_command.zig

@@ -433,9 +433,9 @@ pub const CreateCommand = struct {
                     &archive_context,
                     void,
                     {},
-                    1,
-                    false,
-                    false,
+                    .{
+                        .depth_to_skip = 1,
+                    },
                 );
 
                 if (!create_options.skip_package_json) {

src/compile_target.zig

@@ -269,10 +269,10 @@ pub fn downloadToPath(this: *const CompileTarget, env: *bun.DotEnv.Loader, alloc
                     null,
                     void,
                     {},
-                    // "package/bin"
-                    2,
-                    true,
-                    false,
+                    .{
+                        // "package/bin"
+                        .depth_to_skip = 2,
+                    },
                 ) catch |err| {
                     node.end();
                     Output.err(err,

src/install/extract_tarball.zig

@@ -240,10 +240,11 @@ fn extract(this: *const ExtractTarball, tgz_bytes: []const u8) !Install.ExtractD
                         null,
                         *DirnameReader,
                         &dirname_reader,
-                        // for GitHub tarballs, the root dir is always <user>-<repo>-<commit_id>
-                        1,
-                        true,
-                        log,
+                        .{
+                            // for GitHub tarballs, the root dir is always <user>-<repo>-<commit_id>
+                            .depth_to_skip = 1,
+                            .log = log,
+                        },
                     ),
                 }
 
@@ -265,10 +266,13 @@ fn extract(this: *const ExtractTarball, tgz_bytes: []const u8) !Install.ExtractD
                     null,
                     void,
                     {},
-                    // for npm packages, the root dir is always "package"
-                    1,
-                    true,
-                    log,
+                    .{
+                        .log = log,
+                        // packages usually have root directory `package/`, and scoped packages usually have root `<scopename>/`
+                        // https://github.com/npm/cli/blob/93883bb6459208a916584cad8c6c72a315cf32af/node_modules/pacote/lib/fetcher.js#L442
+                        .depth_to_skip = 1,
+                        .npm = true,
+                    },
                 ),
             },
         }