Fix Stat constructor, remove native code allocation for stat objects (#…

…16694)

src/bun.js/bindings/NodeFSBinding.h

@@ -0,0 +1,9 @@
+
+#include "root.h"
+
+namespace Bun {
+
+void initJSStatsClassStructure(JSC::LazyClassStructure::Initializer& init);
+void initJSBigIntStatsClassStructure(JSC::LazyClassStructure::Initializer& init);
+
+}

src/bun.js/bindings/ZigGlobalObject.cpp

@@ -165,6 +165,8 @@
 #include "JavaScriptCore/RemoteInspectorServer.h"
 #endif
 
+#include "NodeFSBinding.h"
+
 #if !OS(WINDOWS)
 #include <dlfcn.h>
 #endif
@@ -2873,6 +2875,16 @@ void GlobalObject::finishCreation(VM& vm)
                     jsDynamicCast<Zig::GlobalObject*>(init.owner)));
         });
 
+    m_JSStatsClassStructure.initLater(
+        [](LazyClassStructure::Initializer& init) {
+            Bun::initJSStatsClassStructure(init);
+        });
+
+    m_JSStatsBigIntClassStructure.initLater(
+        [](LazyClassStructure::Initializer& init) {
+            Bun::initJSBigIntStatsClassStructure(init);
+        });
+
     m_memoryFootprintStructure.initLater(
         [](const JSC::LazyProperty<JSC::JSGlobalObject, Structure>::Initializer& init) {
             init.set(
@@ -3826,6 +3838,8 @@ void GlobalObject::visitChildrenImpl(JSCell* cell, Visitor& visitor)
     thisObject->m_lazyRequireCacheObject.visit(visitor);
     thisObject->m_lazyTestModuleObject.visit(visitor);
     thisObject->m_memoryFootprintStructure.visit(visitor);
+    thisObject->m_JSStatsClassStructure.visit(visitor);
+    thisObject->m_JSStatsBigIntClassStructure.visit(visitor);
     thisObject->m_NapiClassStructure.visit(visitor);
     thisObject->m_NapiExternalStructure.visit(visitor);
     thisObject->m_NAPIFunctionStructure.visit(visitor);

src/bun.js/bindings/ZigGlobalObject.h

@@ -483,6 +483,8 @@ class GlobalObject : public Bun::GlobalScope {
 
     LazyProperty<JSGlobalObject, Structure> m_JSS3FileStructure;
     LazyProperty<JSGlobalObject, Structure> m_S3ErrorStructure;
+    LazyClassStructure m_JSStatsClassStructure;
+    LazyClassStructure m_JSStatsBigIntClassStructure;
 
     JSObject* cryptoObject() const { return m_cryptoObject.getInitializedOnMainThread(this); }
     JSObject* JSDOMFileConstructor() const { return m_JSDOMFileConstructor.getInitializedOnMainThread(this); }

src/bun.js/bindings/generated_classes_list.zig

@@ -47,8 +47,6 @@ pub const Classes = struct {
     pub const SHA512 = JSC.API.Bun.Crypto.SHA512;
     pub const SHA512_256 = JSC.API.Bun.Crypto.SHA512_256;
     pub const ServerWebSocket = JSC.API.ServerWebSocket;
-    pub const Stats = JSC.Node.StatsSmall;
-    pub const BigIntStats = JSC.Node.StatsBig;
     pub const Subprocess = JSC.Subprocess;
     pub const ResourceUsage = JSC.ResourceUsage;
     pub const TCPSocket = JSC.API.TCPSocket;

src/bun.js/node/node.classes.ts

@@ -161,220 +161,6 @@ export default [
     },
     values: ["arguments", "callback"],
   }),
-  define({
-    name: "Stats",
-    construct: true,
-    finalize: true,
-    klass: {},
-    JSType: "0b11101110",
-
-    // TODO: generate-classes needs to handle Object.create properly when
-    // functions are used. The functions need a fallback implementation to use
-    // getters.
-    supportsObjectCreate: true,
-
-    proto: {
-      isBlockDevice: {
-        fn: "isBlockDevice_",
-        length: 0,
-        enumerable: false,
-        DOMJIT: {
-          returns: "bool",
-          args: [],
-          pure: true,
-        },
-      },
-      isCharacterDevice: {
-        fn: "isCharacterDevice_",
-        length: 0,
-        enumerable: false,
-        DOMJIT: {
-          returns: "bool",
-          args: [],
-          pure: true,
-        },
-      },
-      isDirectory: {
-        fn: "isDirectory_",
-        length: 0,
-        enumerable: false,
-        DOMJIT: {
-          returns: "bool",
-          args: [],
-          pure: true,
-        },
-      },
-      isFIFO: {
-        fn: "isFIFO_",
-        length: 0,
-        enumerable: false,
-        DOMJIT: {
-          returns: "bool",
-          args: [],
-          pure: true,
-        },
-      },
-      isFile: {
-        fn: "isFile_",
-        length: 0,
-        enumerable: false,
-        DOMJIT: {
-          returns: "bool",
-          args: [],
-          pure: true,
-        },
-      },
-      isSocket: {
-        fn: "isSocket_",
-        length: 0,
-        enumerable: false,
-        DOMJIT: {
-          returns: "bool",
-          args: [],
-          pure: true,
-        },
-      },
-      isSymbolicLink: {
-        fn: "isSymbolicLink_",
-        length: 0,
-        enumerable: false,
-        DOMJIT: {
-          returns: "bool",
-          args: [],
-          pure: true,
-        },
-      },
-    },
-    own: {
-      dev: "dev",
-      ino: "ino",
-      mode: "mode",
-      nlink: "nlink",
-      uid: "uid",
-      gid: "gid",
-      rdev: "rdev",
-      size: "size",
-      blksize: "blksize",
-      blocks: "blocks",
-      atimeMs: "atimeMs",
-      mtimeMs: "mtimeMs",
-      ctimeMs: "ctimeMs",
-      birthtimeMs: "birthtimeMs",
-      atime: "atime",
-      mtime: "mtime",
-      ctime: "ctime",
-      birthtime: "birthtime",
-    },
-  }),
-  define({
-    name: "BigIntStats",
-    construct: true,
-    finalize: true,
-    klass: {},
-    JSType: "0b11101110",
-
-    // TODO: generate-classes needs to handle Object.create properly when
-    // functions are used. The functions need a fallback implementation to use
-    // getters.
-    supportsObjectCreate: true,
-
-    proto: {
-      isBlockDevice: {
-        fn: "isBlockDevice_",
-        length: 0,
-        enumerable: false,
-        DOMJIT: {
-          returns: "bool",
-          args: [],
-          pure: true,
-        },
-      },
-      isCharacterDevice: {
-        fn: "isCharacterDevice_",
-        length: 0,
-        enumerable: false,
-        DOMJIT: {
-          returns: "bool",
-          args: [],
-          pure: true,
-        },
-      },
-      isDirectory: {
-        fn: "isDirectory_",
-        length: 0,
-        enumerable: false,
-        DOMJIT: {
-          returns: "bool",
-          args: [],
-          pure: true,
-        },
-      },
-      isFIFO: {
-        fn: "isFIFO_",
-        length: 0,
-        enumerable: false,
-        DOMJIT: {
-          returns: "bool",
-          args: [],
-          pure: true,
-        },
-      },
-      isFile: {
-        fn: "isFile_",
-        length: 0,
-        enumerable: false,
-        DOMJIT: {
-          returns: "bool",
-          args: [],
-          pure: true,
-        },
-      },
-      isSocket: {
-        fn: "isSocket_",
-        length: 0,
-        enumerable: false,
-        DOMJIT: {
-          returns: "bool",
-          args: [],
-          pure: true,
-        },
-      },
-      isSymbolicLink: {
-        fn: "isSymbolicLink_",
-        length: 0,
-        enumerable: false,
-        DOMJIT: {
-          returns: "bool",
-          args: [],
-          pure: true,
-        },
-      },
-    },
-    own: {
-      atime: "atime",
-      atimeMs: "atimeMs",
-      atimeNs: "atimeNs",
-      birthtime: "birthtime",
-      birthtimeMs: "birthtimeMs",
-      birthtimeNs: "birthtimeNs",
-      blksize: "blksize",
-      blocks: "blocks",
-      ctime: "ctime",
-      ctimeMs: "ctimeMs",
-      ctimeNs: "ctimeNs",
-      dev: "dev",
-      gid: "gid",
-      ino: "ino",
-      mode: "mode",
-      mtime: "mtime",
-      mtimeMs: "mtimeMs",
-      mtimeNs: "mtimeNs",
-      nlink: "nlink",
-      rdev: "rdev",
-      size: "size",
-      uid: "uid",
-    },
-  }),
   define({
     name: "Dirent",
     construct: true,
@@ -416,19 +202,12 @@ export default [
         fn: "isSymbolicLink",
         length: 0,
       },
-      name: {
-        getter: "getName",
-        cache: true,
-      },
-      path: {
-        getter: "getPath",
-        cache: true,
-      },
-      parentPath: {
-        // @since node v20.12.x
-        getter: "getPath",
-        cache: true,
-      },
+    },
+
+    own: {
+      name: "getName",
+      path: "getPath",
+      parentPath: "getPath",
     },
   }),
   define({

src/bun.js/node/node_fs_stat_watcher.zig

@@ -26,9 +26,9 @@ const log = bun.Output.scoped(.StatWatcher, false);
 
 fn statToJSStats(globalThis: *JSC.JSGlobalObject, stats: bun.Stat, bigint: bool) JSC.JSValue {
     if (bigint) {
-        return StatsBig.new(StatsBig.init(stats)).toJS(globalThis);
+        return StatsBig.init(stats).toJS(globalThis);
     } else {
-        return StatsSmall.new(StatsSmall.init(stats)).toJS(globalThis);
+        return StatsSmall.init(stats).toJS(globalThis);
     }
 }