Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose validation state via Controls context #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Expose validation state via Controls context #28

wants to merge 1 commit into from

Conversation

lingsuann02
Copy link
Contributor

This PR gives Losen the ability to track which steps are invalid.

@lingsuann02 lingsuann02 requested review from kmkr and rix1 September 3, 2020 10:01
@lingsuann02 lingsuann02 self-assigned this Sep 3, 2020
rix1
rix1 reviewed Sep 3, 2020
View reviewed changes
Copy link
Member

@rix1 rix1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'm missing some context (🥁) of why this was done. If I knew I would be able to provide better feedback/suggestions :)

why

@lingsuann02
Copy link
Contributor Author

lingsuann02 commented Sep 3, 2020 •
edited
Loading

Looks good, but I'm missing some context (🥁) of why this was done. If I knew I would be able to provide better feedback/suggestions :)

This was done to better support validation in Losen.
By persisting validation state in Losen, there is no need for clients to persist validation state to handle display of validation errors in the client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix1 rix1 rix1 left review comments

@kmkr kmkr Awaiting requested review from kmkr

Assignees

@lingsuann02 lingsuann02

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lingsuann02 @rix1