Merge pull request #44 from otovo/espenra/custom-serializer-after-lis…

…t-bug

Custom serializer + list bug

portabletext_html/renderer.py

@@ -66,7 +66,7 @@ def render(self) -> str:
 
             if list_nodes and not is_list(node):
                 tree = self._normalize_list_tree(list_nodes)
-                result += ''.join([self._render_node(n, Block(**node), list_item=True) for n in tree])
+                result += ''.join([self._render_node(n, list_item=True) for n in tree])
                 list_nodes = []  # reset list_nodes
 
             if is_list(node):

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = 'portabletext-html'
-version = '1.1.2'
+version = '1.1.3'
 description = "HTML renderer for Sanity's Portable Text format"
 homepage = 'https://github.com/otovo/python-sanity-html'
 repository = 'https://github.com/otovo/python-sanity-html'

tests/fixtures/custom_serializer_node_after_list.json

@@ -0,0 +1,20 @@
+[
+  {
+    "_key": "e5b6e416e6e9",
+    "_type": "block",
+    "children": [
+      { "_key": "3bbbff0f158b", "_type": "span", "marks": [], "text": "resers" }
+    ],
+    "level": 1,
+    "listItem": "bullet",
+    "markDefs": [],
+    "style": "normal"
+  },
+  {
+    "_key": "73405dda68e0",
+    "_type": "extraInfoBlock",
+    "extraInfo": "This informations is not supported by Block",
+    "markDefs": [],
+    "style": "normal"
+  }
+]

tests/test_rendering.py

@@ -1,10 +1,18 @@
 import html
 import json
 from pathlib import Path
+from typing import Optional
 
 import pytest
 
 from portabletext_html.renderer import MissingSerializerError, UnhandledNodeError, render
+from portabletext_html.types import Block
+
+
+def extraInfoSerializer(node: dict, context: Optional[Block], list_item: bool) -> str:
+    extraInfo = node.get('extraInfo')
+
+    return f'<p>{extraInfo}</p>'
 
 
 def load_fixture(fixture_name) -> dict:
@@ -59,3 +67,10 @@ def test_invalid_node():
     fixture = load_fixture('invalid_node.json')
     with pytest.raises(UnhandledNodeError):
         render(fixture)
+
+
+def test_custom_serializer_node_after_list():
+    fixture = load_fixture('custom_serializer_node_after_list.json')
+    output = render(fixture, custom_serializers={'extraInfoBlock': extraInfoSerializer})
+
+    assert output == '<div><ul><li>resers</li></ul><p>This informations is not supported by Block</p></div>'