fix buffer delete mode not persisting removals #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that buffer delete mode does not persist deleting multiple entries when one quits nvim immediately after deleting several bookmarks. In such cases, the plugin will persist deleting only the first entry while retaining the rest.
How to reproduce:
Add several bookmarks (more than 1)
Enter buffer delete mode, delete more than 1 entry
Quit nvim
Open nvim again and open the buffer you deleted the marks on.
You'll notice that only one selected mark was deleted from the cache file.
This PR fixes this issue by making
buffer_persist.removetake a table (delete_mode) or a single index for other circumstances.