-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: keep mainstream toolchain versioning format #19
base: master
Are you sure you want to change the base?
Conversation
There may be value in my original approach in #17 (as described in #17 (comment)) but I didn't want to foist this setup on you unless you felt it was worthwhile. If you want to pursue this, reverting #18 and adding the At the moment, users can either install the latest version (the The downside is that adding a new version is a little trickier, as you have to add a new formula and update (or add) aliases. With the existing setup, this is only necessary when a new major version is released.
Aliases are omitted from
instead of:
There's maybe something to be said for always displaying aliases in I'm busy with some other |
I'm a bit worried about maintainability. Confusion is easy between If we go down this rabbit hole, should we provide formulae for all the arm gcc versions on developer.arm.com? I would keep I would only provide That being said, I'm afraid it will bring confusion regarding Do people really rely on a Finally, the goal of these formulae was to have arm-gcc up-to-date and easily available, not to provide all the versions needed for every RTOS available out there. It's easy enough for zephyr, contiki and the others to fork the repo if they want and point to the version they need. The burden of maintaining that should not be on us. ARM Mbed does exactly that https://github.com/ARMmbed/homebrew-formulae The reason I'm a bit conflicted about this PR is that besides the discussions the 3 of us are having, no one ever asked for that. So is it really worthwhile? |
That would be my point yes
We would update the link, since we are the ones deciding which version is considered our
I do understand that, but thinking about it, we are tracking the GNU Arm Embedded Toolchain binaries, and not mainstream GCC releases, so we end up defeating the purpose to have real up-to-date GCC for arm releases. My proposal is not to provide toolchains "for every RTOS available out there", but simply to provide the formulae for the toolchains our mainstream provides. My example meant to show that using the latest version on a constantly changing toolchain is not so common as it might seem, for instance, a minor release update doesnt mean that it wont break things for some stacks. Also, I don't really think it is a burden to maintain, its a one time addition every quarter (not even every quarter)
Fair enough, and comes as an argument for what I said previously, but Im not so sure that just because only the 3 of us started this discussion means that nobody wants it. For instance, I wasnt using this repo for all my arm needs because it didnt fit this exact purpose, had to edit the formula before and freeze the version manually. So, since this is a bit of a direction change, Id suggest to keep this as an RFC to keep some visibility on this proposal and re-evaluate if we get more thumbs up on this. Sounds fair? |
Alright, you convinced me, let's move forward! :) So we should:
Bonus tasks:
|
yey!!
yeah, we could do it ad hoc
To give some context, I think the main point of those should be to keep the same behaviour current users of this repo expect, that being, having the latest versions of major releases. With that said, I think it's a question for the users of that feature in particular. You being one, If not linking
Im not sure what that implies, but sounds good!
I agree, altho I'm torn between |
From my experience with brew/core, for osx-cross/avr we have something different: avr-gcc is pointing to avr-gcc@9 not avr-gcc@10 -- this is because avr support will be dropped in GCC 11 and that for avr people tend to not like to be cutting edge, so we kept @9 the default. I think that having the following aliases should be sufficient for now:
This way people installing
They even call is |
Yeah, I think |
@leojrfs where are we with this PR? |
Sorry, I forgot about this PR. I'll give it a go if I find time this month. |
@leojrfs I'll convert this PR to draft but reading through our discussion I still think it makes sense to move forward if you have time. I myself have been in the situation where updating from |
please read #17 (comment)
This PR reverts @samford work and adds aliases to keep the current behaviour
Im not sure why the aliases don't show up in the
brew search arm-gcc-bin
but they seem to workbrew info gcc@8
, any hints?