Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add S3 support to check-access, basic test infra #29

Merged
merged 9 commits into from
Dec 6, 2024
Merged

Conversation

detjensrobert
Copy link
Contributor

Uploads a small test file to the S3 bucket, then tries to download it as an anonymous user.

Also includes some basic test infrastructure to test against, and fixes category field not being populated correctly when parsing challenge config.

Resolves #12.

@detjensrobert detjensrobert self-assigned this Nov 12, 2024
@detjensrobert
Copy link
Contributor Author

detjensrobert commented Nov 12, 2024

Unit tests need to be updated to parse via the new parsing library, and I have a WIP branch for that. Ignore for now.

Copy link

@cacama-valvata cacama-valvata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great and also thanks for testing documentation in tests/README.md, looks like tests are failing though

Spins up a local minikube cluster and registry and S3/minio containers.

Signed-off-by: Robert Detjens <[email protected]>
Signed-off-by: Robert Detjens <[email protected]>
@detjensrobert detjensrobert merged commit 54665ea into main Dec 6, 2024
3 checks passed
@detjensrobert detjensrobert deleted the dr/s3 branch December 6, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement check-access for S3 asset bucket
2 participants