RC v2.1.0 #113
Merged
RC v2.1.0 #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PS: I hope Bryce sleeps a little better knowing a repository out there in the world is slightly closer to 100% coverage. 🌛
## Changes - Use Dependency Injection on Commands for CommandClasses - Add some real tests for Commands - Fully covered! 🎉 - Core now injects an a client and commands into every command - Allows for reuse of commands in help function and other functions of the future :) - Commands now take an optional 3rd parameter that includes: - client - commands - Config - commandsPathGlob now lives in the config - commandTemplateFile has a new home - If we decide to later allow for ENV override on these it will be trivial. - These could probably be removed if they're only used in one place, but I also enjoy the dependency injection for testing purposes. Even the tests are using the real file paths This test is more like an integration test I think. This is fine. - Help command is now more readable and easier to test with dependency injection. - Full coverage ;)
I decided to remove the following from the config: - commandsPathGlob - commandTemplateFile They are only being used in a single place anyways. I also made sure they'll be easy to extract later if we ever need to inject them.
Also add some padding to match the original. Now that I can see what it looks like in the snap shot I can easily check :)
Seems to just be my stuff. I need to get my lint extension running on WSL :0!
A larger effort needs to be around this to makes all of these optional since not all commands will utilize all of these in the execute interface.
Use 13.7.2 so it matches up with the `@types/node` version Stay on the fresh edge of versioning 🎉
These have been sitting around
## More Info - discordjs/discord.js#3978 - microsoft/TypeScript#33591
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included PRs