Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This solves #79 #85

Merged
merged 4 commits into from
Oct 31, 2018
Merged

This solves #79 #85

merged 4 commits into from
Oct 31, 2018

Conversation

CharlesHopman
Copy link
Contributor

This solves the issue of tags coming on top of the project names...

Before :

capture2

After :

capture

@alexdor
Copy link
Member

alexdor commented Oct 21, 2018

Hi @CharlesHopman nice work : ) The changes you made though don't align with the designs https://github.com/ossn/fixme/blob/master/screens/desktop/Mozilla_Fixme_Screen03_Projects.png could you try to solve #79 in a way that keeps the page complaint with the designs?

@CharlesHopman
Copy link
Contributor Author

Hi @alexdor can you please specify the changes you want me to make ? :)

@alexdor
Copy link
Member

alexdor commented Oct 21, 2018

If you see the designs the logos are at the bottom right corner and a small part of the logo has been cut out. With your changes, the logos don't have a cut out anymore

@CharlesHopman
Copy link
Contributor Author

Hey @alexdor thank you for the information :) I’ll make the changes soon.

@CharlesHopman
Copy link
Contributor Author

@alexdor I have aligned the logo as in the design please review :)

@alexdor
Copy link
Member

alexdor commented Oct 30, 2018

@CharlesHopman could you make the checks pass?

@CharlesHopman
Copy link
Contributor Author

Hey, @alexdor all the checks are passed and I hope its all good :)

@alexdor alexdor merged commit 93aa1bb into ossn:master Oct 31, 2018
@alexdor
Copy link
Member

alexdor commented Oct 31, 2018

Thanks @CharlesHopman looks good : )

@CharlesHopman
Copy link
Contributor Author

@alexdor No problem :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants