Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "Project" suffix to the type of project IDs #9392

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sschuberth
Copy link
Member

Please have a look at the individual commit messages for the details.

@sschuberth sschuberth requested a review from a team as a code owner November 7, 2024 12:41
@sschuberth sschuberth marked this pull request as draft November 7, 2024 12:41
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.91%. Comparing base (151858e) to head (6f5d2eb).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #9392   +/-   ##
=========================================
  Coverage     67.91%   67.91%           
  Complexity     1262     1262           
=========================================
  Files           244      244           
  Lines          8724     8724           
  Branches        909      909           
=========================================
  Hits           5925     5925           
  Misses         2422     2422           
  Partials        377      377           
Flag Coverage Δ
test 36.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sschuberth sschuberth force-pushed the project-id-type branch 4 times, most recently from a0d2bfe to 212fcad Compare November 7, 2024 16:19
To avoid one root cause of duplicate project vs package IDs, add a
"Project" suffix to the `type` of project IDs.

This change does not affect IDs used in package curation or package
configurations as these really only apply to packages, not projects.

Signed-off-by: Sebastian Schuberth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant