-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using ROS 2 Launch For Large Projects #1151
Comments
You can assign me to this, since I've already finished with this tutorial: #1152 |
Ah woops, I actually meant an different issue, but no worries this one is up next. |
The tutorials is really long and I lost oversight at one point. Also there were errors so I couldn't complete the tutorial This needs fixing I have here a list of suggestion for either myself or someone else to look at if they'd like to fix this:
Some global thoughts on why the flow of the tutorial wasn't great either. It might be too much in one tutorial to all show in one project/launch file. And if people come to this point, this might be too 'advanced' to be in the form of a tutorial. I'm wondering if it is better suited as an sort of API documentation or user-guide with minimal examples of each case., that can be referred to after users have gone through the basics (such they can do it later when they make their own project). Might reduce the maintainer load of this tutorial/doc as well. |
There is a partial fix proposed in ros2/ros2_documentation#4454, however, there is something wrong with the carrot1 transform... it seems to be missing in the full tutorial so I think we are missing a node here. Perhaps with this proposal and draft PR open, you could consider closing this issue. |
Ah ofcourse, the 'fixed_frame_node' also included the carrot1 broadcaster. User error! my bad That covers of what I thought was the biggest error of the tutorial. That means that this issue can be closed with the PR ros2/ros2_documentation#4454 just adding some small fixes. |
Fantastic, thank you for opening that and for testing! |
Check the documentation for the 'Using ROS 2 Launch For Large Projects' page
Configuration
Links
Process
Step 1 - I was able to follow the documentation.
Step 2 - The documentation seemed clear to me.
Step 3 - The documentation didn't have any obvious errors.
The text was updated successfully, but these errors were encountered: