Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link rclcpp_action if required #10

Merged
merged 4 commits into from
Aug 2, 2023
Merged

Link rclcpp_action if required #10

merged 4 commits into from
Aug 2, 2023

Conversation

Yadunund
Copy link
Member

@Yadunund Yadunund commented Aug 2, 2023

Fix #9

Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
@Yadunund Yadunund force-pushed the yadu/fix_action_dep branch 2 times, most recently from 1ef5d39 to aab0999 Compare August 2, 2023 09:25
Signed-off-by: Yadunund <[email protected]>
Copy link
Member

@koonpeng koonpeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source of the CI error is with ros release, because ros packages does not include version constraints so apt does not keep the versions in sync. I imagine fixing this on the ROS side will be hard.

@Yadunund Yadunund merged commit bb28b43 into main Aug 2, 2023
@Yadunund Yadunund deleted the yadu/fix_action_dep branch August 2, 2023 09:39
@koonpeng koonpeng mentioned this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rclcpp_action dependency not linked
2 participants