-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP add Ignition #378
base: master
Are you sure you want to change the base?
WIP add Ignition #378
Conversation
Signed-off-by: Mikael Arguedas <[email protected]>
Signed-off-by: Mikael Arguedas <[email protected]>
Signed-off-by: Mikael Arguedas <[email protected]>
Signed-off-by: Mikael Arguedas <[email protected]>
Signed-off-by: Mikael Arguedas <[email protected]>
Signed-off-by: Mikael Arguedas <[email protected]>
Signed-off-by: Mikael Arguedas <[email protected]>
Signed-off-by: Mikael Arguedas <[email protected]>
Signed-off-by: Mikael Arguedas <[email protected]>
Signed-off-by: Mikael Arguedas <[email protected]>
Blueprint has 7 more months of support and is the version being used by the current phase of the Subterranean challenge, so I suggest keeping it.
It does run simulation, but the default world is more conservative than Gazebo's and doesn't even include a sun and ground plane. This might change though.
You could start with
No plans to change that
Oops, fix here: gazebo-release/gz-launch2-release#1
Nope, but hey, they've been working happily side-by-side 😁
I suspect there isn't a way yet. CC @j-rivero |
Thanks @chapulina for the timely and thorough answer!
Yeah amazing 🎉 though confusing ^^ |
Signed-off-by: Mikael Arguedas <[email protected]>
Signed-off-by: Mikael Arguedas <[email protected]>
Changes performed, new review requested
Do we want to use the same --no-suggested-depends like in other library PRs? |
My original thinking was to keep those dissociated as I don't know when the other PR will land and decision in the other PR may impact the use of @ruffsl some extra questions for the ignition images
|
That sounds fine, we'll wait for the other PRs to stabilize.
I'd shoot for introducing the server tags we'd like to support, and push them upstream. I think even the current gazebo library tags have gui packages, so I'm not sure that made a difference. I just think moving the tag to a new repo later might be disruptive. Although the other thing we could do is to only support a tag for gui/client install/ then add a headless server related tag when ignition comes up with one, and rebase the osrf gui tag to build from the library tag we'd upstream.
I'm not sure you'd ever want to have the GUI to launch as the default command entry point, as unless someone is going spawn the container using rocker, it'd just crash. I think the client related tag should just keep the default cmd that it would inherit from the server tag. |
Yeah maybe that makes more sense. Once ignition provide more granular packages and ways to install client and server separately we can consider pushing them to the official library
Arguably maybe it should do nothing ? like the ROS images where you enter a container with an environment seupt but nothing running. similarly we dont launch a rosmaster in the ROS 1 images. |
Good point. There was a good cause to do this with gazebo, as running gazebo was perhaps the main purpose of the gazebo images, but now with gazebo being only a part of the ignition ecosystem, perhaps it makes sense to follow the approach in the ros images. |
Hi peeps, what's the status on this? Anything we can help with? |
no updates on this ATM mostly because time is lacking
Is there now a way to install only the server side of things without bundling in all the GUI dependencies ? this would go a long way in providing images following the docker guidelines There doesn't seem to be arm packages for ignition-citadel or ignition-dome. Is arm64 not a supported platform ? |
Nope. I ticketed gazebosim/gz-sim#398 to keep track of this.
Dome is already there on Focal, and almost there on Bionic. That's being tracked on gazebo-tooling/release-tools#297 but it's low priority for us at the moment. We don't have an issue tracking Citadel yet. |
I started revisiting this in light of ignition name change. AFAICT:
@chapulina Could you provide feedback on the former points ? Side troubleshooting question: Locally the citadel images seem to do what's expected, however the fortress ones crash with the following message: |
👍🏽
I haven't looked into these templates. What parameters are passed to a template?
I don't know what the rules are for hosting under the official docker library. Is it ok to install GUI dependencies, but not require them for running? From Fortress we support headless rendering, so you could run with
We have some, but they're supported at best effort and may be broken for extended periods of time.
👍🏽
We need a release with gazebosim/gz-sim#1463, I can make it soon. And to confirm, does it actually crash or does it shutdown gracefully? |
This PR along with osrf/docker_templates#84 provide boilerplate to generate ignition docker files and dockerfiles for Ignition blueprint and citadel.
To be done before merging:
Open questions / remarks (ping @j-rivero @chapulina @ruffsl) :
ign gazebo -s
:gazebo
in the package URLhttp://packages.osrfoundation.org/gazebo/$ID-stable
, will this be changed/mirrored toignition
or should we hard code it in the templates ?ignition-citadel
and more preciselylibignition-launch2-dev
depends on bothignition-gazebo2
andlibignition-gazebo3-dev
?! Is it normal to depend on 2 different versions of Gazebo?ignition-citadel
depends onlibboost-all-dev
and a ton oflibignition-*-dev
packages. Is there another package I should install to have only the runtime libraries in the docker image? (The currentignition-citadel
image is 1.46GB which is huge)