Develop 1.0 #55
Open
Develop 1.0 #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es_test (polish -> polishing)
…s through the API. Also reversed the change to .gitmodules.
…, update_codegen_defines. Added osqp_struct_codegen_defines.cpp and updated osqp_struct.h. Updated the relevant .m files (codegen.m still needs work). Minor refactoring to osqp_mex.cpp.
Comment on lines
+255
to
+166
| if (!strcmp("delete", cmd)) { | ||
| osqp_cleanup(osqpData->solver); | ||
| destroyObject<OsqpData>(prhs[1]); | ||
| // Warn if other commands were ignored | ||
| if (nlhs != 0 || nrhs != 2) | ||
| mexWarnMsgTxt("Delete: Unexpected arguments ignored."); | ||
| return; | ||
| } |
There was a problem hiding this comment.
I'm a bit confused about this. During the constructor ("new"), I dynamically create a new OSQPCodegenDefines object (see Line 159). Seeing how osqp_cleanup destroys osqpData->solver, I thought I would have to free osqpData->defines manually. However, when I did that, the program crashed because destroyObject tries to destroy the already freed memory. What I don't understand is why this doesn't happen with osqpData->solver, which is freed by osqp_cleanup.
AmitSolomonPrinceton
force-pushed
the
develop-1.0
branch
from
a7a5e89 to
391fe8f
Compare
Develop 1.0 codegen
…les that do not contain the word "License" in them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support to codegen, changes to c_source, memory,