imposex assessments - all individuals are zeros #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially deals with #500
Removes the station / year / species combinations where all the individuals are zeros from the estimation of the cut points. This should simplify convergence.
The confidence intervals for these station / year / species combinations are then introduced later on in an ad-hoc fashion. These confidence intervals needs to be replaced by correct likelihood intervals in a subsequent pull request.
Have also relabelled
ctsm.VDS.index.optasordinal_theta_estandctsm.VDS.index.clasordinal_theta_clin a move towards making the routines link to the distribution of the data, rather than to a particular determinand. (I might change these names again before I'm done here, but it's a move in the right direction.)Have tested on a subset of UK data.
Conscious there is a lot more work to be done to get the imposex assessments integrated in a good way.