Bug #496 fix summary output for imposex data #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hallareinert
approved these changes
Dec 2, 2024
annelaerkes
approved these changes
Dec 2, 2024
This was referenced Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #496
Fixes the bug in
write_summary_tablewhich occurs when only imposex data are being assessed. Did so by adding a functioninitialise_assessment_summarythat initialises the summary output in a standardised way and makes it harder to omit important variables. This also begins the process of unifying the various assessment functions that share a lot of (repeated) code.initialise_assessment_summarystill allows for output variables that are specific to particular determinands; e.g.imposex_classfor VDS assessments.Tested on UK imposex data.