-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auxiliary variables plot #476
Conversation
@annelaerkes @hallareinert |
…alled explicitly in the markdown files. Have corrected this. Should resolve the checks.
@annelaerkes @hallareinert |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an exiting addition. My only comment is on the explanatory text:
"At present, it is only possible to change the last three variable for biota and the last two variables for sediment. For example, for metals in sediment, you might specify auxiliary = c("AL", "LI")
to plot aluminium and lithium concentrations instead of aluminium and organic carbon."
To me this description is unclear. Am I understanding it correct, that only the auxiliary variables can be changed, not the contaminants? If so, can we write that instead of the reference to "last two/three"?
…fully this is better. Happy to keep going until I get it right ;)
@annelaerkes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this explanation is better, thanks
Issue #409
plot_assessment
now also plots the raw data with key auxiliary variables. This is achieved by 'file_type = "auxiliary"
. The default variables are:The choice of auxiliary variables can be altered using the
auxiliary
argument, although the options here are still limited.Tested with the HELCOM and AMAP data.
Documentation updated.
AMAP vignette (which demonstrates
plot_assessment
) updated.To close off this issue, still need to: