Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auxiliary variables plot #476

Merged
merged 3 commits into from
Aug 27, 2024
Merged

Conversation

RobFryer
Copy link
Contributor

Issue #409
plot_assessment now also plots the raw data with key auxiliary variables. This is achieved by 'file_type = "auxiliary". The default variables are:

  • biota: concentration, LNMEA, DRYWT%, LIPIDWT%
  • sediment: non-normalised concentration, normalised concentration, AL, CORG
  • water: no plots are currently produced

The choice of auxiliary variables can be altered using the auxiliary argument, although the options here are still limited.

Tested with the HELCOM and AMAP data.
Documentation updated.
AMAP vignette (which demonstrates plot_assessment) updated.

To close off this issue, still need to:

  • update multi-series plots
  • update ratio plots
  • reintroduce these plots into the html reports for each time series
  • remove warning about the distribution of MNC data

@RobFryer
Copy link
Contributor Author

@annelaerkes @hallareinert
One of the checks has failed - I'll look at this over the next couple of days, update code, and let you know when done.

…alled explicitly in the markdown files. Have corrected this. Should resolve the checks.
@RobFryer
Copy link
Contributor Author

@annelaerkes @hallareinert
I renamed a couple of internal plotting functions, but forgot that they are called explicitly in the markdown. Have corrected this and the checks now work. Please can one of you review and, if happy, merge.

Copy link
Contributor

@annelaerkes annelaerkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an exiting addition. My only comment is on the explanatory text:

"At present, it is only possible to change the last three variable for biota and the last two variables for sediment. For example, for metals in sediment, you might specify auxiliary = c("AL", "LI") to plot aluminium and lithium concentrations instead of aluminium and organic carbon."

To me this description is unclear. Am I understanding it correct, that only the auxiliary variables can be changed, not the contaminants? If so, can we write that instead of the reference to "last two/three"?

…fully this is better. Happy to keep going until I get it right ;)
@RobFryer
Copy link
Contributor Author

@annelaerkes
I agree - it wasn't clear. I've had another go and hopefully it is better this time round. Still a bit convoluted though!

Copy link
Contributor

@annelaerkes annelaerkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this explanation is better, thanks

@annelaerkes annelaerkes merged commit a385b68 into osparcomm:develop Aug 27, 2024
1 check passed
@RobFryer RobFryer deleted the auxiliary_graphics branch September 3, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants