print power metrics #415
Merged
print power metrics #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issue 407
morungos
requested changes
Jan 10, 2024
| @@ -392,9 +402,13 @@ ctsm.web.AC <- function(assessment_ob, classification) { | |||
| #' a csv file). | |||
| #' @param determinandGroups optional, a list specifying `labels` and `levels` | |||
| #' to label the determinands | |||
| #' @param classColour Specifies the colour scheme for the output symbology. | |||
| #' Will be changed soon. | |||
| #' @param classColour `r lifecycle::badge("experimental")` Specifies the | |||
There was a problem hiding this comment.
I think a badge has crept in here, where it shouldn't be.
|
Review done. If I am extra-grumpy today, blame the UK Passport Office 🤣. And I'm sorry. |
|
@morungos Passport offices can be a real pain! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #407
Allows users to print the extra power metrics for lognormally distributed data
The code is not elegant, but does the job, and should suffice until the whole routine is over-hauled.
@morungos If you could review and approve today, then I will continue with the changes to the symbology in the summary table tomorrow.