Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow summaries to be appended #414

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Conversation

morungos
Copy link
Contributor

@morungos morungos commented Jan 9, 2024

Resolves #399

Testing Notes

With this, passing append as TRUE to write_summary_table should add to any existing summary file, or create it if it does not yet exist. A unit test has been added to work this out.

Technical Notes

Over and above documentation and unit tests, all this does is add a new append parameter write_summary_table, and pass the value through to readr::write_excel_csv, with some appropriate defaulting.

Resolves osparcomm#399

## Testing Notes

With this, passing `append` as `TRUE` to `write_summary_table` should add to any existing summary file, or create it if it does not yet exist. A unit test has been added to work this out.

## Technical Notes

Over and above documentation and unit tests, all this does is add a new `append` parameter `write_summary_table`, and pass the value through to `readr::write_excel_csv`, with some appropriate defaulting.
@morungos morungos added the enhancement New feature or request label Jan 9, 2024
@morungos morungos requested a review from RobFryer January 9, 2024 19:40
Copy link
Contributor

@hansmy hansmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good user friendliness, and stored in the right folder too. :)

@hansmy hansmy merged commit 08522a4 into osparcomm:develop Jan 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement simple summary report append option in summary table write function
2 participants