Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute power metrics #406

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Compute power metrics #406

merged 1 commit into from
Jan 3, 2024

Conversation

RobFryer
Copy link
Contributor

@RobFryer RobFryer commented Jan 2, 2024

Resolves #143

Computes the suite of power metrics required by AMAP. The user can tailor these using the new control argument to run_assessment; in particular by specifying the target power and the target detectable trend.

Have also made the construction of the original dtrend metric (detectable trend on the log-scale) compatible with the power control parameters.

Have tested (on a limited set of data) and updated the external data vignette to illustrate the use of the control argument with the target power and trend used by AMAP in it's last mercury assessment.

Have added some documentation and filled in some gaps in other documentation so that roxygen2 doesn't throw any warnings.

The power metrics are contained in a new element of each assessment list. They do not yet print out in the summary table. I will raise a new issue for this and deal with it when I work on the summary tables.

Copy link
Contributor

@hansmy hansmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to get more on the imposex and power ++ before release.

@hansmy hansmy merged commit 4a6ef5b into osparcomm:develop Jan 3, 2024
1 check passed
@RobFryer RobFryer deleted the issue_143_1 branch February 4, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

power functions
2 participants