-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Genesis Simple Love #64
base: develop
Are you sure you want to change the base?
Conversation
|
||
case 'love' : | ||
|
||
$data_title = __('Love', 'genesis'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like I need to actually make these all translatable strings, but that will have to be done separately. However, the correct text domain should be genesis-simple-share
not genesis
.
Thanks, I added several comments. Pretty much all of it is very nitpick code standard stuff. The pull request looks good over all but ideally the text domains, and code standards should be fixed. You may find it helpful to view the comments inline on the files over randomly like they are in the pull request discussion. https://github.com/copyblogger/genesis-simple-share/pull/64/files |
Done :) Thank you for the guidelines. It's my first time forking and pulling other people's code and I'm using sublime text which doesn't follow your formatting. I'll keep this items on mind, will be very helpfull for me also. I'm sending the pull request again, apology for late response. Cheers, |
Hi,
I've successfully integrated the Genesis Simple Love Plugin : https://wordpress.org/plugins/genesis-simple-love/ . Feel free to check and contact me anytime when you need anything. Thanks!
Cheers,
phpbits