-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cyprus motorway shields #558
base: main
Are you sure you want to change the base?
Conversation
@@ -3062,6 +3062,16 @@ export function loadShields(shieldImages) { | |||
Color.shields.white | |||
); | |||
|
|||
// Cyprus | |||
shields["cy:national"] = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
national
is an unusual name for what seems to be a network of motorways. cy:motorway
would be more appropriate, as would cy:A-road
considering the A
prefix.
It's unclear whether this tagging was invented by a Cypriot. Is there a Cyprus OSM community that we can contact about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to Wikipedia, “motorway” is equivalent to the A-road network, but it does sound like B-roads and E-roads could also be part of a national numbering scheme. Maybe this was an attempt to conform to what was perceived as international terminology (not the first time I’ve seen it). The tag was introduced in changeset 44730739.
The community index doesn’t list any local community for Cyprus, and the national tagging page doesn’t provide any guidance on route relations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm hesitant to solidify a tagging scheme that may complicate tagging guidelines for the remaining route networks in Cyprus. It's unclear how other networks in Cyprus should be tagged if we decide to support cy:national
.
Cyprus is a small country, and the mapping community may only be a few people. Perhaps we could ask the Greek community for their perspective—certainly some of them would be familiar with Cyprus, and if there are any Cypriot mappers, there's a chance we may find them there.
This comment was marked as resolved.
This comment was marked as resolved.
186b39f
to
72678d8
Compare
How should we proceed on this? Is it worth proposing a route network scheme for Cyprus and advertise it in the appropriate channels, and implement it if there's no objections? |
Sounds like a plan. @1ec5 By the way, the hexagonal icons can be replaced with the new draw functions here. |
What would be a sane scheme for A, B, and E roads? |
Added a shield definition for A roads (motorways) in Cyprus, as well as Akrotiri and Dhekelia, a British Overseas Territory. So far only A roads have been mapped; B roads (main roads) and E roads (secondary roads) don’t have relations yet.