Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinct food court icon #1170

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

wmisener
Copy link
Collaborator

PR #1153, which added restaurants, also rendered food courts (amenity=food_court) with the same restaurant knife-and-fork icon. But food courts aren't exactly restaurants: they contain restaurants. In a sense, to dust off my SAT analogies, a restaurant is to a food court like a bus stop is to a bus station. Thus, I propose a food court icon that is the restaurant icon inscribed in a circle, following the logic Americana has already taken in #845 for bus and train stations.
poi_restaurant_circle

Old:
Screenshot 2024-11-22 at 9 50 22 PM
New:
Screenshot 2024-11-22 at 9 50 32 PM

One slightly unfortunate aspect is that I had the fork and knife icon is pretty much 20x20, so I had to shrink them a bit to fit within a 20px diameter circle. So the utensils appear a bit smaller in the food court icon than in nearby restaurant icons, but hopefully the circle's added prominence makes up for it. I guess one possible solution would be to shrink the restaurant icon so that it's not 20x20 (some icons aren't, like bus stops), but I don't know that it's necessary just for this.

The icon appears at z15, one before restaurants. It can show up without a label at that zoom, like supermarkets and gas stations. (Side note: which icons do and don't appear without labels at certain zooms is still quite ad hoc, the style would probably benefit from some stated logic for it)
Screenshot 2024-11-22 at 9 50 11 PM

More samples:
Screenshot 2024-11-22 at 9 51 31 PM
Screenshot 2024-11-22 at 9 51 48 PM
Screenshot 2024-11-22 at 9 52 42 PM

Funnily enough, the food court icon would now be the first POI that shows up in the style for many large malls. I don't think that's a flaw per se, but rather a sign that things like malls and department stores should probably be fairly high priorities for POIs the project should tackle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant