feat: add iso_oscar_singular_[coeff/poly]_ring #4342
+453
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the plan we agreed on #976, introducing
This is similar to
iso_oscar_gap
, although here we must have two separate version.This PR here applies it only as far as we need it to fix #976.
Comments/thoughts:
singular_poly_ring
andsingular_generators
uses left, which can (and will with the right input) trigger ambiguity errors. But these might be fixed later.FqField
if the field is not absolute.CC: @fieker @ederc