Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splits groebner.jl into parts #4250

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Conversation

ederc
Copy link
Member

@ederc ederc commented Oct 28, 2024

This PR splits groebner.jl into meaningful parts. It adds a global groebner/groebner.jl file that just includes all other parts like it is done in Groups.

Copy link
Member

@joschmitt joschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@joschmitt
Copy link
Member

This has some potential for merge conflicts, but right now the only pull request that edits this file is #4244 from what I can see.

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 89.80044% with 46 lines in your changes missing coverage. Please review.

Project coverage is 84.59%. Comparing base (16517cf) to head (841ddb5).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/Rings/groebner/hilbert-driven.jl 67.81% 28 Missing ⚠️
src/Rings/groebner/modular.jl 92.95% 5 Missing ⚠️
src/Rings/groebner/f4.jl 73.33% 4 Missing ⚠️
src/Rings/groebner/general.jl 93.33% 4 Missing ⚠️
src/Rings/groebner/leading-ideal.jl 77.77% 2 Missing ⚠️
src/Rings/groebner/fglm.jl 95.83% 1 Missing ⚠️
src/Rings/groebner/generators.jl 96.29% 1 Missing ⚠️
src/Rings/groebner/highest-corner.jl 90.90% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4250   +/-   ##
=======================================
  Coverage   84.59%   84.59%           
=======================================
  Files         631      640    +9     
  Lines       85072    85072           
=======================================
  Hits        71970    71970           
  Misses      13102    13102           
Files with missing lines Coverage Δ
src/Rings/groebner/reduce.jl 100.00% <100.00%> (ø)
src/Rings/groebner/transformation-matrix.jl 100.00% <100.00%> (ø)
src/Rings/groebner/fglm.jl 95.83% <95.83%> (ø)
src/Rings/groebner/generators.jl 96.29% <96.29%> (ø)
src/Rings/groebner/highest-corner.jl 90.90% <90.90%> (ø)
src/Rings/groebner/leading-ideal.jl 77.77% <77.77%> (ø)
src/Rings/groebner/f4.jl 73.33% <73.33%> (ø)
src/Rings/groebner/general.jl 93.33% <93.33%> (ø)
src/Rings/groebner/modular.jl 92.95% <92.95%> (ø)
src/Rings/groebner/hilbert-driven.jl 67.81% <67.81%> (ø)

@lgoettgens lgoettgens merged commit eb407e5 into oscar-system:master Oct 29, 2024
29 checks passed
HechtiDerLachs pushed a commit to HechtiDerLachs/Oscar.jl that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants