Use BinaryWrapper to point GAP packages to singular/polymake executables #4132
+40
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4132 +/- ##
=======================================
Coverage 84.69% 84.70%
=======================================
Files 627 627
Lines 84304 84305 +1
=======================================
+ Hits 71405 71408 +3
+ Misses 12899 12897 -2
|
fingolfin
force-pushed
the
mh/gap-polymaking-singular-paths
branch
from
5c8ee22
to
94fb5c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have GAP.jl 0.11, I can finally submit this as a PR. But only as draft as I didn't finish the Polymake support on macOS (@benlorenz gave me a hint how to do it, which I record in this patch, but I just didn't get around to following up on it).
Posting this so it doesn't get forgotten. Also now @ThomasBreuer can access it easily.