Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GAP.Packages.build(name) #1066

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lgoettgens
Copy link
Member

@lgoettgens lgoettgens commented Nov 21, 2024

Some progress towards #1065.

As pointed out in #1065 (comment), this function may need to copy a package from an artifact directory to the user pkgdir to have it in a location that is both writable and PackageManager:CompilePackage does not complain about.

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Project coverage is 74.68%. Comparing base (8f4a1a1) to head (b1b36f6).

Files with missing lines Patch % Lines
src/packages.jl 0.00% 22 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1066      +/-   ##
==========================================
- Coverage   74.97%   74.68%   -0.30%     
==========================================
  Files          55       55              
  Lines        4560     4550      -10     
==========================================
- Hits         3419     3398      -21     
- Misses       1141     1152      +11     
Files with missing lines Coverage Δ
src/packages.jl 60.46% <0.00%> (-12.44%) ⬇️

... and 8 files with indirect coverage changes

---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant