Move wait_still_screen to the start of the loop #20662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a loop in the `sles4sap/wizard_hana_install` test module, which cycles until the `sap-product-installation` needle matches. On SUTs with only one disk, this is a good solution as it allows the test to continue faster, but on SUTs with more disks, it's possible that the dialog prompting the user to select the disk where HANA is going to be installed takes a few seconds to appear, which can cause the module to wrongly match with `sap-product-installation` which is the window behind the disk selection dialog. This commit moves the `wait_still_screen` call from the end of the loop to the start of the same loop. Idea is that module will wait until screen settles before attempting to match either the disk selection dialog or the `sap-product-installation` needle, giving it more time to wait for the disk selection dialog to be shown.
alvarocarvajald
requested review from
a-kpappas,
Amrysliu,
BillAnastasiadis,
emiura,
jankohoutek,
lilyeyes,
lpalovsky and
mpagot
as code owners
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a loop in the
sles4sap/wizard_hana_installtest module, which cycles until thesap-product-installationneedle matches. On SUTs with only one disk, this is a good solution as it allows the test to continue faster, but on SUTs with more disks, it's possible that the dialog prompting the user to select the disk where HANA is going to be installed takes a few seconds to appear, which can cause the module to wrongly match withsap-product-installationwhich is the window behind the disk selection dialog.This commit moves the
wait_still_screencall from the end of the loop to the start of the same loop. Idea is that module will wait until screen settles before attempting to match either the disk selection dialog or thesap-product-installationneedle, giving it more time to wait for the disk selection dialog to be shown.Verification runs