Fix use of unitialized value while splitting UPDATE_ADD_CONFLICT #20656
+3
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-kpappas
force-pushed
the
defined_conflicts
branch
from
45de155
to
0016322
Compare
We get a "Use of uninitialized value in split" warning in while splitting the UPDATE_ADD_CONFLICT variable as this is most often not set. This is fixed by splitting only when the variable is defined. Additionally the loop was removed as `push` gets lists as arguments and `split` returns the list in list context. Related Ticket: poo#170005
a-kpappas
force-pushed
the
defined_conflicts
branch
from
0016322
to
886f319
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We get a "Use of uninitialized value in split" warning in while splitting the UPDATE_ADD_CONFLICT variable as this is most often not set. This is fixed by splitting only when the variable is defined.
Additionally the loop was removed as
pushgets lists as arguments andsplitreturns the list in list context.15-SP6 15-SP515-SP4 15-SP2 12-SP5