WIP virt_autotest: Set up the 2 new purchased machines in OSD as ipmi worker #20613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guoxuguang
force-pushed
the
leon/poo167890
branch
from
a6cd8c0
to
56de9d2
Compare
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
guoxuguang
force-pushed
the
leon/poo167890
branch
from
56de9d2
to
985d7c5
Compare
okurz
reviewed
Nov 15, 2024
lib/ipmi_backend_utils.pm
Outdated
Comment on lines
359
to
364
| sub ipmitool { | ||
| my ($cmd) = @_; | ||
| my $ipmi_options = $bmwqemu::vars{IPMI_OPTIONS} // '-I lanplus'; | ||
|
|
||
| my @cmd = ('ipmitool', '-I', 'lanplus', '-H', $bmwqemu::vars{IPMI_HOSTNAME}, '-U', $bmwqemu::vars{IPMI_USER}, '-P', $bmwqemu::vars{IPMI_PASSWORD}); | ||
| my @cmd = ('ipmitool', split(' ', $ipmi_options), '-H', $bmwqemu::vars{IPMI_HOSTNAME}, '-U', $bmwqemu::vars{IPMI_USER}, '-P', $bmwqemu::vars{IPMI_PASSWORD}); | ||
| push(@cmd, split(/ /, $cmd)); |
There was a problem hiding this comment.
ok, that would fix the one specific issue. But I strongly suggest to not replicate this code from os-autoinst but rather use the functions from there directly and as required extend the backend.
There was a problem hiding this comment.
Good point, try to call ipmi_cmdline() from backend/ipmi.pm here.
guoxuguang
force-pushed
the
leon/poo167890
branch
2 times, most recently
from
844ee00
to
014b2c0
Compare
guoxuguang
force-pushed
the
leon/poo167890
branch
from
014b2c0
to
affe3da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bare-metal5
gi-guest_developing-on-host_developing-kvm PASS
prj2_host_upgrade_sles15sp6_to_developing_kvm PASS
prj4_guest_upgrade_sles15sp6_on_sles15sp6-kvm PASS
gi-guest_developing-on-host_developing-xen Fail by bsc#1233225