Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use add_on_products to enable modules without registration #20555

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use add_on_products to enable modules without registration #20555

wants to merge 1 commit into from
+124 −22

Conversation

waynechen55
Copy link
Contributor

@waynechen55 waynechen55 commented Nov 5, 2024 •
edited
Loading

@waynechen55 waynechen55 changed the title [WIP] Use add_on_products to enable modules without registration Use add_on_products to enable modules without registration Nov 5, 2024
@waynechen55
Copy link
Contributor Author

@alice-suse @guoxuguang @Julie-CAO @RoyCai7 @nanzhg @tbaev Please have a look.

@waynechen55 waynechen55 force-pushed the wayne/poo#168253_sles15sp7_disconnect_cc_area_adapt_autoyast_registration_2 branch 11 times, most recently from 726e8bd to 3a1dab8 Compare November 7, 2024 07:46
@RoyCai7
Copy link
Contributor

RoyCai7 commented Nov 7, 2024

LGTM

alice-suse
alice-suse reviewed Nov 8, 2024
View reviewed changes
products/sle/main.pm Outdated
@@ -864,7 +864,9 @@ elsif (get_var("VIRT_AUTOTEST")) {
loadtest "virt_autotest/update_package";
# Skip reset_partition for s390x due to there just be 42Gib disk space for each s390x LPAR
loadtest "virt_autotest/reset_partition" if (!is_s390x and get_var('VIRT_PRJ1_GUEST_INSTALL'));
loadtest "virt_autotest/reboot_and_wait_up_normal" if (!get_var('AUTOYAST') && get_var('REPO_0_TO_INSTALL'));
if (!(check_var('SCC_REGISTER', 'installation') or check_var('REGISTER', 'installation')) and get_var('REPO_0_TO_INSTALL')) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can is_registered_sles be somehow used here?

alice-suse
alice-suse reviewed Nov 8, 2024
View reviewed changes
data/virt_autotest/host_unattended_installation_files/autoyast/dev_host_15.xml.ep
@@ -41,7 +41,7 @@
</listentry>
% }
</add_on_products>
</add-on-->
</add-on>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about dev_host_12.xml.ep? Now 12sp5 enters ltss, and needs LTSS add-on if no registration.

@alice-suse
Copy link
Contributor

I notice this from the verification logs. When registration is disabled, the reg_code and addons are still configured, which does not quite synced with no-registration status. It is not critical, but better to be improved. It is fine to merge as it is now and improve it later though.

<suse_register>
<do_registration config:type="boolean">false</do_registration>
<reg_server/>
<reg_code>INTERNAL-USE-...</reg_code>
<install_updates config:type="boolean">true</install_updates>
<addons config:type="list">
<addon>
<name>sle-module-legacy</name>
<version>15.6</version>
<arch>x86_64</arch>
<release_type/>
</addon>
</addons>
</suse_register>

@alice-suse
Copy link
Contributor

One thing that matters to confirm: now BJ proxy scc is not available, but I believe it will come later. Will it be possible to switch back to proxy scc registration way without code change, but only setting change?

@waynechen55 waynechen55 force-pushed the wayne/poo#168253_sles15sp7_disconnect_cc_area_adapt_autoyast_registration_2 branch from 3a1dab8 to 7df90f2 Compare November 8, 2024 03:39
@waynechen55
Copy link
Contributor Author

I notice this from the verification logs. When registration is disabled, the reg_code and addons are still configured, which does not quite synced with no-registration status. It is not critical, but better to be improved. It is fine to merge as it is now and improve it later though.

<suse_register>
<do_registration config:type="boolean">false</do_registration>
<reg_server/>
<reg_code>INTERNAL-USE-...</reg_code>
<install_updates config:type="boolean">true</install_updates>
<addons config:type="list">
<addon>
<name>sle-module-legacy</name>
<version>15.6</version>
<arch>x86_64</arch>
<release_type/>
</addon>
</addons>
</suse_register>

I will not change this part, because do_registration=false. This is reasonable.

@waynechen55 waynechen55 force-pushed the wayne/poo#168253_sles15sp7_disconnect_cc_area_adapt_autoyast_registration_2 branch from 7df90f2 to 030401c Compare November 8, 2024 03:43
@waynechen55
Copy link
Contributor Author

One thing that matters to confirm: now BJ proxy scc is not available, but I believe it will come later. Will it be possible to switch back to proxy scc registration way without code change, but only setting change?

There is already HOST_SCC_URL parameter in autoyast.

@waynechen55 waynechen55 force-pushed the wayne/poo#168253_sles15sp7_disconnect_cc_area_adapt_autoyast_registration_2 branch 3 times, most recently from abe01dc to c344bce Compare November 11, 2024 07:08
@waynechen55
Use add_on_products to enable modules without registration
ba72312 
For test scenarios that do not do registration, using add_on_products
can help enable modules and install packages without reigstration.
And module virt_autotest/reboot_and_wait_up_normal will be loaded for
unregistered released products.
@waynechen55 waynechen55 force-pushed the wayne/poo#168253_sles15sp7_disconnect_cc_area_adapt_autoyast_registration_2 branch from c344bce to ba72312 Compare November 11, 2024 07:15
@alice-suse
Copy link
Contributor

I notice this from the verification logs. When registration is disabled, the reg_code and addons are still configured, which does not quite synced with no-registration status. It is not critical, but better to be improved. It is fine to merge as it is now and improve it later though.

<suse_register>
<do_registration config:type="boolean">false</do_registration>
<reg_server/>
<reg_code>INTERNAL-USE-...</reg_code>
<install_updates config:type="boolean">true</install_updates>
<addons config:type="list">
<addon>
<name>sle-module-legacy</name>
<version>15.6</version>
<arch>x86_64</arch>
<release_type/>
</addon>
</addons>
</suse_register>

I will not change this part, because do_registration=false. This is reasonable.

This does not follow high quality code rules IMO. And it can be easily achieved by adding condition check about registration status for the whole block of suse_register -- move this line to the line before <suse_register>.

@alice-suse
Copy link
Contributor

@Julie-CAO Can you visit github now? Look forward to your review :) !

@waynechen55 waynechen55 marked this pull request as draft November 12, 2024 06:02
@waynechen55 waynechen55 marked this pull request as ready for review November 25, 2024 07:44
@waynechen55
Copy link
Contributor Author

@Julie-CAO Can you visit github now? Look forward to your review :) !

Ready for review @Julie-CAO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-suse alice-suse alice-suse left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waynechen55 @RoyCai7 @alice-suse