Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add podman pod, build and network quadlet testing #20397

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

KuxaBeast
Copy link
Contributor

@KuxaBeast KuxaBeast commented Oct 15, 2024

Improved the containers/podman_quadlet.pm to include tests for pod, build and network quadlets.

Copy link
Contributor

@grisu48 grisu48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is already a great start! Check some of the comments and then we're having a second look at it.

For a first PR this is really good. Feel free to ping me if you need help with any of the pending topics.

tests/containers/podman_quadlet.pm Outdated Show resolved Hide resolved
tests/containers/podman_quadlet.pm Outdated Show resolved Hide resolved
tests/containers/podman_quadlet.pm Show resolved Hide resolved
tests/containers/podman_quadlet.pm Show resolved Hide resolved
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

  • Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files.

Copy link
Contributor

@grisu48 grisu48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job so far. Still some improvements, but we're getting there!

tests/containers/podman_quadlet.pm Outdated Show resolved Hide resolved
tests/containers/podman_quadlet.pm Show resolved Hide resolved
lib/main_containers.pm Outdated Show resolved Hide resolved
Copy link
Member

@pdostal pdostal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is cool! 😲 Can you just ftr mention more VRs?

@grisu48
Copy link
Contributor

grisu48 commented Nov 25, 2024

Please rebase

Copy link
Contributor

@grisu48 grisu48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments, otherwise LGTM. We're almost there!

tests/containers/podman_quadlet.pm Outdated Show resolved Hide resolved
tests/containers/podman_quadlet.pm Outdated Show resolved Hide resolved
@KuxaBeast KuxaBeast force-pushed the feature/quadlet branch 3 times, most recently from df4bf0e to 1ea64a2 Compare November 27, 2024 14:50
@KuxaBeast
Copy link
Contributor Author

KuxaBeast commented Nov 27, 2024

That is cool! 😲 Can you just ftr mention more VRs?

Updated the Tumbleweed VR. SLE <16 and Micro <6.0 are intentionally ignored, but I can add some anyway...

Change dir variable name

Co-authored-by: Felix Niederwanger <[email protected]>

Don't parse JSON

Exclude pod validation for SLE<16

Enable for SLE

Allow only for tumbleweed and SLE 16+

Revert "Exclude pod validation for SLE<16"

This reverts commit d8e3064.

Remove unneeded JSON import

Add image pull phase and increase image build timeout

Improve run conditions and increase image pull delay

Improve file population and cleanup daemon-reload

Adjust for upstream Quadlet update

containers/podman#24334

Quadlet build units no longer use RemainAfterExit=yes by default.
@ricardobranco777 ricardobranco777 merged commit fdec0a4 into os-autoinst:master Nov 28, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants