-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add podman pod, build and network quadlet testing #20397
Add podman pod, build and network quadlet testing #20397
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this is already a great start! Check some of the comments and then we're having a second look at it.
For a first PR this is really good. Feel free to ping me if you need help with any of the pending topics.
2d97c03
to
a6cfed9
Compare
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
985e290
to
5caffa9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job so far. Still some improvements, but we're getting there!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is cool! 😲 Can you just ftr mention more VRs?
Please rebase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor comments, otherwise LGTM. We're almost there!
df4bf0e
to
1ea64a2
Compare
Updated the Tumbleweed VR. SLE <16 and Micro <6.0 are intentionally ignored, but I can add some anyway... |
f437a96
to
56ef14b
Compare
Change dir variable name Co-authored-by: Felix Niederwanger <[email protected]> Don't parse JSON Exclude pod validation for SLE<16 Enable for SLE Allow only for tumbleweed and SLE 16+ Revert "Exclude pod validation for SLE<16" This reverts commit d8e3064. Remove unneeded JSON import Add image pull phase and increase image build timeout Improve run conditions and increase image pull delay Improve file population and cleanup daemon-reload Adjust for upstream Quadlet update containers/podman#24334 Quadlet build units no longer use RemainAfterExit=yes by default.
56ef14b
to
01698bf
Compare
Improved the
containers/podman_quadlet.pm
to include tests for pod, build and network quadlets.