Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation and normalizes code comments for attribution #140

Merged
merged 4 commits into from
Apr 8, 2024

Conversation

jpower432
Copy link
Contributor

@jpower432 jpower432 commented Oct 2, 2023

Description

PR to improve design documents and provide additional links and comments for adaptation/attribution and better understand of code design and sources of inspiration. This is part one to addressing #128.

Type of change

  • This change requires a documentation update

How Has This Been Tested?

Documentation and comment updates only.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Requires updates to the Getting Started Guide

@jpower432 jpower432 added this to the v0.5.0 milestone Oct 2, 2023
@jpower432 jpower432 requested a review from afflom October 4, 2023 17:03
- Adds attrbution for adapted directed Graph and iterator implementation
- Adds reference to NodeBudget adaptation

Signed-off-by: Jennifer Power <[email protected]>
Removes out of data documentation under docs/design.
Moves node information into a README.md under the nodes
package and adds example usage snippets.

Signed-off-by: Jennifer Power <[email protected]>
Updates attribution comments and add TODO comments
Adds a defer statement to close io.ReadCloser types return when
unused to avoid leaking resources.

Signed-off-by: Jennifer Power <[email protected]>
@jpower432 jpower432 force-pushed the docs/design-docs-and-comments branch from 2b51c31 to 88cdd05 Compare October 14, 2023 19:24
@jpower432 jpower432 marked this pull request as ready for review November 8, 2023 14:45
@jpower432 jpower432 changed the title [WIP] Update documentation and normalizes code comments for attribution. Update documentation and normalizes code comments for attribution. Nov 8, 2023
@jpower432 jpower432 requested a review from usrbinkat November 8, 2023 14:46
@jpower432 jpower432 changed the title Update documentation and normalizes code comments for attribution. Update documentation and normalizes code comments for attribution Apr 5, 2024
@afflom afflom merged commit 1fefb53 into ortelius:main Apr 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants