Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Test other infoFormat when getFeatureInfo fails #2112

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: Test other infoFormat when getFeatureInfo fails #2112

wants to merge 4 commits into from

Conversation

jokd
Copy link
Contributor

@jokd jokd commented Dec 13, 2024

Fixes #2108 Try different infoFormats if getFeatureInfo request fails with the configured infoFormat (application/geojson or application/geo+json)

@jokd
Copy link
Contributor Author

jokd commented Dec 13, 2024

Will have to rewrite this since the linter didn't like my loop

@jokd jokd marked this pull request as draft December 13, 2024 13:05
@jokd jokd marked this pull request as ready for review December 14, 2024 08:19
johnnyblasta
johnnyblasta approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@johnnyblasta johnnyblasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Nice that it sets the correct format on the layer, so subsequent click don't have to round trip with wrong format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnyblasta johnnyblasta johnnyblasta approved these changes

Assignees
No one assigned
Labels
PR approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Try other info_formats when getfeatureinfo request fails.
2 participants
@jokd @johnnyblasta